cleanup(pystar): inline @bazel_tools and @platforms references#1531
Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom Nov 2, 2023
Merged
cleanup(pystar): inline @bazel_tools and @platforms references#1531rickeylev merged 1 commit intobazel-contrib:mainfrom
rickeylev merged 1 commit intobazel-contrib:mainfrom
Conversation
The location of the @bazel_tools and @platforms repositories were originally part of the semantics.bzl config because performing rewrites on the code as part of the Bazel code export process was too difficult. With the direction being reversed (imported instead of exported), and the scope of the codebase being reduced (just rules_python instead of the entire Bazel codebase), it's easier to perform copybara rewrites. In particular, the `"//` strings are problematic to rewrite because they look like intra-repo references instead of parts of a larger expression.
945daf2 to
85f3ab7
Compare
aignas
approved these changes
Nov 2, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The location of the
@bazel_toolsand@platformsrepositories were originally part of the semantics.bzl config because performing rewrites on the code as part of the Bazel code export process was too difficult.With the direction being reversed (imported instead of exported), and the scope of the codebase being reduced (just rules_python instead of the entire Bazel codebase), it's easier to perform copybara rewrites.
In particular, the
"//strings are problematic to rewrite because they look like intra-repo references instead of parts of a larger expression.