Skip to content

tests: explicitly disable bzlmod for pip_parse_vendored example#1529

Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom
rickeylev:bzlmod.pip_parse_vendored
Oct 31, 2023
Merged

tests: explicitly disable bzlmod for pip_parse_vendored example#1529
rickeylev merged 1 commit intobazel-contrib:mainfrom
rickeylev:bzlmod.pip_parse_vendored

Conversation

@rickeylev
Copy link
Copy Markdown
Collaborator

@rickeylev rickeylev commented Oct 31, 2023

Bazel at head enables bzlmod by default, but the pip_parse_vendored example doesn't work
under bzlmod.

To fix, explicitly disable bzlmod because vendoring requirements.bzl files isn't necessary
under bzlmod. This is because the pip bzlmod extension handles creating repos directly
from the locked requirements file (which is the output of the pip dependency resolution
process).

While we're here, also enable incompatible_generate_aliases = True, in preparation for
that being switched.

@rickeylev rickeylev added this pull request to the merge queue Oct 31, 2023
Merged via the queue into bazel-contrib:main with commit 2a074f8 Oct 31, 2023
@rickeylev rickeylev deleted the bzlmod.pip_parse_vendored branch October 31, 2023 23:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants