test: make compile_pip_requirements_test_from_external_workspace work with bzlmod#1528
Merged
rickeylev merged 2 commits intobazel-contrib:mainfrom Nov 1, 2023
Conversation
aignas
approved these changes
Oct 31, 2023
… with bzlmod Bazel at head enables bzlmod by default, so the tests must also be updated to be bzlmod compatible. Also makes compile_pip_requirements ignore its convenience symlinks. This allows locally running the "from external" workspace test even if the compile_pip_requirements workspace previously had convenience symlinks in it from other builds. Work towards bazel-contrib#1520
ab2e198 to
a9fee51
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bazel at head enables bzlmod by default, so the tests must also be
updated to be bzlmod compatible.
Also makes compile_pip_requirements ignore its convenience symlinks.
This allows locally running the "from external" workspace test even if
the compile_pip_requirements workspace previously had convenience
symlinks in it from other builds.
Work towards #1520