chore(pip_parse, gazelle): generate/use hub repo aliases by default#1525
Merged
aignas merged 6 commits intobazel-contrib:mainfrom Nov 1, 2023
Merged
chore(pip_parse, gazelle): generate/use hub repo aliases by default#1525aignas merged 6 commits intobazel-contrib:mainfrom
aignas merged 6 commits intobazel-contrib:mainfrom
Conversation
506615a to
81214dc
Compare
81214dc to
2e8780e
Compare
Collaborator
|
What's the incompatible part again? I can't remember what the potential incompatibility is. The existing Let's just make sure to note this in the changelog/docs. Otherwise lgtm. |
rickeylev
approved these changes
Oct 31, 2023
Summary: - Flip the generation of aliases in `pip_repository`. - Flip usage of aliases in `gazelle`. - Remove usage of the old flags from the example code. - Update the `gazelle` manifest generator to leave the `gazelle_python.yaml` manifest unchanged for people who have `use_pip_repository_aliases = True` in their `BUILD.bazel` files. Once they remove the flag, the `gazelle_python.yaml` will be updated.
Collaborator
Author
|
I think for |
a6b5ce0 to
3916156
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes
pip_parse.incompatible_generate_aliases = Truethe default. This only affectsworkspace builds; it is already the default for bzlmod.
Summary:
pip_repository.gazelle.gazellemanifest generator to leave thegazelle_python.yamlmanifest unchanged for people who haveuse_pip_repository_aliases = Truein theirBUILD.bazelfiles.Once they remove the flag, the
gazelle_python.yamlwill be updated.multi_pip_parseto handle sub-hub repositories wherethe
all_requirementsreturns aliased targets.Fixes #1498