chore!: disable pip_install and remove from examples and tests#1510
Merged
aignas merged 4 commits intobazel-contrib:mainfrom Oct 19, 2023
Merged
chore!: disable pip_install and remove from examples and tests#1510aignas merged 4 commits intobazel-contrib:mainfrom
aignas merged 4 commits intobazel-contrib:mainfrom
Conversation
Collaborator
|
What is the mention of compile_pip_requirements for? pip_install is already just a pass-through to pip_parse. i.e. migration is just Otherwise LGTM |
rickeylev
approved these changes
Oct 19, 2023
6d987e4 to
e6ed401
Compare
Collaborator
Author
|
Reworded, I've seen somewhere in the main README.md about needing to use |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This causes
pip_installto fail by default. Theallow_pip_installarg of it can beset to True to temporarily re-enable it.
Towards #1498.