docs: Better explain when and how to use toolchains for bzlmod#1349
Merged
rickeylev merged 2 commits intobazel-contrib:mainfrom Jul 31, 2023
Merged
docs: Better explain when and how to use toolchains for bzlmod#1349rickeylev merged 2 commits intobazel-contrib:mainfrom
rickeylev merged 2 commits intobazel-contrib:mainfrom
Conversation
This explains the different ways to register toolchains and how to use them. Also fixes python_aliases -> python_versions repo name
aignas
approved these changes
Jul 30, 2023
Collaborator
aignas
left a comment
There was a problem hiding this comment.
Thanks for this explanation, I think it becomes much clearer of what is possible and how the toolchains can be used.
That said, I wonder if if we should advise users to only use X.Y instead of X.Y.Z in the python_version field. All of the docs only have examples in that case and I am wondering if saying python_version = "3.11.1" even makes sense here.
Collaborator
Author
|
Yeah good point, we should be explicit about that. Only major.minor is
supported. If major.minor.patch works, it's just incidental.
…On Sat, Jul 29, 2023, 8:20 PM Ignas Anikevicius ***@***.***> wrote:
***@***.**** approved this pull request.
Thanks for this explanation, I think it becomes much clearer of what is
possible and how the toolchains can be used.
That said, I wonder if if we should advise users to only use X.Y instead
of X.Y.Z in the python_version field. All of the docs only have examples
in that case and I am wondering if saying python_version = "3.11.1" even
makes sense here.
—
Reply to this email directly, view it on GitHub
<#1349 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AIEXQ6STQUH7JS6T5CWGV23XSXHINANCNFSM6AAAAAA22L7PQ4>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
Collaborator
Author
|
Updated the attribute docs for the python_version attributes. |
Solumin
approved these changes
Jul 31, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This explains the different ways to register toolchains and how to use them.
Also fixes python_aliases -> python_versions repo name