fix(bzlmod)!: Changing repository name "python_aliases" to "python_versions"#1304
Merged
rickeylev merged 1 commit intobazel-contrib:mainfrom Jul 10, 2023
Merged
Conversation
I think this name is more informative for a public API. The functionality it exposes are rules/macros that use a specific Python version to be used. These aren't really aliases. This commit renames "python_aliases" to "python_versions". This is a breaking change.
rickeylev
approved these changes
Jul 10, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I think this name is more informative for a public API. The functionality it exposes are rules/macros that use a specific Python version to be used. These aren't really aliases.
This commit renames "python_aliases" to "python_versions". This isn't technically a breaking
change because bzlmod support is still beta, but we'll flag it as such just in case.
BREAKING CHANGE:
python_aliasesrepo is renamed topython_versions. You will need to eitherupdate references from
@python_aliasesto@python_versions, or use repo-remappingto alias the old name (
use_repo(python, python_aliases="python_versions"))Closes #1273