fix: add format() calls to glob_exclude templates#1285
Merged
chrislovecnm merged 1 commit intobazel-contrib:mainfrom Jul 6, 2023
Merged
fix: add format() calls to glob_exclude templates#1285chrislovecnm merged 1 commit intobazel-contrib:mainfrom
format() calls to glob_exclude templates#1285chrislovecnm merged 1 commit intobazel-contrib:mainfrom
Conversation
Contributor
Author
|
EDIT: Seems to be fixed on |
format() calls to glob_exclude templates
daveboutcher
approved these changes
Jun 26, 2023
rickeylev
approved these changes
Jun 26, 2023
Contributor
Author
|
@rickeylev do you know why the build is failing on Windows? |
auto-merge was automatically disabled
July 6, 2023 14:05
Head branch was pushed to by a user without write access
61ec702 to
3f55a21
Compare
Contributor
Author
|
@rickeylev I think this is ready to go now. I rebased onto main and that seems to have helped. |
Contributor
|
@lpulley do you know if we are pulling in too many files with windows? I’m guessing we need to add a pattern for windows as well. If you don’t work with windows can you please file an issue so we investigate it? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, Python toolchain
:filesand:py3_runtimeinclude some unnecessary files. This is because these globs result in literallylib/libpython{python_version}.soetc., which do not match anything. The formatting needs to be applied here since it will not be applied later.I believe this was introduced by a47c6cd.