feat(gazelle): allow passing multiple files to the manifest generator#1235
Closed
aignas wants to merge 1 commit intobazel-contrib:mainfrom
Closed
feat(gazelle): allow passing multiple files to the manifest generator#1235aignas wants to merge 1 commit intobazel-contrib:mainfrom
aignas wants to merge 1 commit intobazel-contrib:mainfrom
Conversation
For certain workflows it is useful to calculate the integrity hash of the manifest file based on a number of requirements files. The requirements locking is usually done by executing a script on each platform and having gazelle manifest generator be aware that more than one requirements file may affect the outcome (e.g. the wheels that get passed to modules map may come from `multi_pip_parse` rule) is generally useful. This change modifies the `generator` to support multiple `--requirements` flag specification and uses all files that got passed to generate the final integrity hash.
Collaborator
Author
|
This is probably not the best way, because we can use multiple requirements file and a |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For certain workflows it is useful to calculate the integrity hash of
the manifest file based on a number of requirements files. The
requirements locking is usually done by executing a script on each
platform and having gazelle manifest generator be aware that more than
one requirements file may affect the outcome (e.g. the wheels that get
passed to modules map may come from
multi_pip_parserule) is generallyuseful.
This change modifies the
generatorto support multiple--requirementsflag specification and uses all files that got passedto generate the final integrity hash.
NOTE: This may require users to regenerate the
gazelle_python.yamlfiles dueto a change in integrity, otherwise this is a backwards compatible change.