py_proto_libray: Add api_deps to transitive_sources#1091
Closed
comius wants to merge 1 commit intobazel-contrib:mainfrom
Closed
py_proto_libray: Add api_deps to transitive_sources#1091comius wants to merge 1 commit intobazel-contrib:mainfrom
comius wants to merge 1 commit intobazel-contrib:mainfrom
Conversation
Collaborator
|
LGTM, but... Was there a failure you found from them missing? I'm not sure what, if anything, is actually using PyInfo.transitive_sources. |
rickeylev
approved these changes
Feb 24, 2023
Contributor
Author
|
It seems, this is not needed. This is related to bazelbuild/bazel#17545. I tested that change with the main branch of rules_python and it also works. Any way and the other with 18.1, files from proto runtime were missing. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Sources from runtime needed by py_proto_library are not added to PyInfo.
What is the new behavior?
The sources are added.
Does this PR introduce a breaking change?