-
-
Notifications
You must be signed in to change notification settings - Fork 678
bzlmod pip.parse default is leaking across to the other_module #1548
Copy link
Copy link
Closed
Labels
type: bzlmodbzlmod workbzlmod work
Description
In the bzlmod example, if you examine the @other_module_pip//absl_py:BUILD.bazel contents, you will see:
$ cat bazel-bzlmod/external/rules_python~override~pip~other_module_pip/absl_py/BUILD.bazel
package(default_visibility = ["//visibility:public"])
alias(
name = "absl_py",
actual = ":pkg",
)
alias(
name = "pkg",
actual = select(
{
"@@rules_python~override//python/config_settings:is_python_3.11.6": "@other_module_pip_311_absl_py//:pkg",
"//conditions:default": "@other_module_pip_39_absl_py//:pkg",
},
),
)
alias(
name = "whl",
actual = select(
{
"@@rules_python~override//python/config_settings:is_python_3.11.6": "@other_module_pip_311_absl_py//:whl",
"//conditions:default": "@other_module_pip_39_absl_py//:whl",
},
),
)
alias(
name = "data",
actual = select(
{
"@@rules_python~override//python/config_settings:is_python_3.11.6": "@other_module_pip_311_absl_py//:data",
"//conditions:default": "@other_module_pip_39_absl_py//:data",
},
),
)
alias(
name = "dist_info",
actual = select(
{
"@@rules_python~override//python/config_settings:is_python_3.11.6": "@other_module_pip_311_absl_py//:dist_info",
"//conditions:default": "@other_module_pip_39_absl_py//:dist_info",
},
),
)%However, the other_module_pip does not have anything set up for 3.9 and is setting 3.11 as the default toolchain version for the sub-module. It seems that this line may be wrong and we need to get the default version per module that the extension is used in.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
type: bzlmodbzlmod workbzlmod work