Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: bazel-contrib/rules_python
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0.39.0
Choose a base ref
...
head repository: bazel-contrib/rules_python
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0.40.0
Choose a head ref
  • 9 commits
  • 21 files changed
  • 4 contributors

Commits on Nov 13, 2024

  1. refactor(pkg_aliases): create a macro for creating whl aliases (#2391)

    This just cleans up the code and moves more logic from the
    repository_rule
    (i.e. generation of `BUILD.bazel` files) to loading time (macro
    evaluation).
    This makes the unit testing easier and I plan to also move the code that
    is
    generating config setting names from filenames to this new macro, but
    wanted to
    submit this PR to reduce the review chunks.
    
    Summary:
    - Add a new `pkg_aliases` macro.
    - Move logic and tests for creating WORKSPACE aliases.
    - Move logic and tests bzlmod aliases.
    - Move logic and tests bzlmod aliases with groups.
    - Add a test for extra alias creation.
    - Use `whl_alias` in `pypi` extension integration tests.
    - Improve the serialization of `whl_alias` for passing to the pypi hub
    repo.
    
    Related to #260, #2386, #2337, #2319 - hopefully cleaning the code up
    will make
    it easier to address those feature requests later.
    
    ---------
    
    Co-authored-by: Richard Levasseur <richardlev@gmail.com>
    aignas and rickeylev authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    7b95ea6 View commit details
    Browse the repository at this point in the history
  2. chore: change bcr presubmit to drop bazel 6, add last_rc (bazel 8) (#…

    …2404)
    
    This removes Bazel 6 and adds last_rc (Bazel 8) in our BCR presubmit
    config. Right now, BCR releases fail because they try to test with Bazel
    6, which doesn't work.
    rickeylev authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    1738faf View commit details
    Browse the repository at this point in the history
  3. deps: update to gazelle 0.40.0 (#2403)

    This allows us to drop the patch for removing native.sh_binary
    
    Work towards #2378
    rickeylev authored Nov 13, 2024
    Configuration menu
    Copy the full SHA
    541bcba View commit details
    Browse the repository at this point in the history

Commits on Nov 14, 2024

  1. chore!: remove requirements.txt for the twine publishing tool (#2401)

    `requirements_linux.txt` in the same folder should be used instead.
    
    Fixes #2242
    aignas authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    c8ccd22 View commit details
    Browse the repository at this point in the history
  2. ci: add last_rc, remove extraneous pystar configs (#2405)

    Run the bzlmod example with last_rc to match the BCR config. This should
    help catch any
    issues before a BCR release occurs.
    
    Along the way, cleanup the extraneous pystar configs. The rules_python
    Starlark
    implementation is enabled by default, and disabling it is unsupported.
    rickeylev authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    273cbd1 View commit details
    Browse the repository at this point in the history
  3. fix: upgrade to rules_proto 7.0.2 to pickup fix for Bazel 9 (#2408)

    The ProtoInfo was removed in Bazel 9, but earlier versions of
    rules_proto still refer to it.
    
    This was fixed in rules_proto 7.0.0.
    
    Fixes #2400
    
    ---------
    
    Co-authored-by: Ivo List <ilist@google.com>
    rickeylev and comius authored Nov 14, 2024
    Configuration menu
    Copy the full SHA
    155efce View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2024

  1. fix: keep import path values if Bazel-builtin PyInfo is removed (#2415)

    The collect_imports() function added import strings from BuiltinPyInfo
    if it was non-None.
    However, operator precedence caused the `if-else` ternary to ignore both
    list comprehensions
    (one for PyInfo and one for BuiltinPyInfo) if BuiltinPyInfo was None.
    
    To fix, I rewrote the function as a regular for loop to eliminate the
    ambiguous looking
    ternary expression.
    
    Fixes: #2414
    rickeylev authored Nov 16, 2024
    Configuration menu
    Copy the full SHA
    b304fc6 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2024

  1. docs: tell how to do pyc-only builds (#2417)

    Someone one Slack asked if this was possible and how to do, so document
    it for better
    visibility. There's a lot of flags, so its easy to not see how to do
    this.
    rickeylev authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    7467c6f View commit details
    Browse the repository at this point in the history
  2. chore: update changelog for 0.40.0 (#2416)

    Add new version links and headers
    rickeylev authored Nov 17, 2024
    Configuration menu
    Copy the full SHA
    1944874 View commit details
    Browse the repository at this point in the history
Loading