build: Update bazel_skylib dependency#829
Merged
thesayyn merged 1 commit intobazel-contrib:mainfrom Oct 15, 2025
Merged
Conversation
Newer versions address a warning about a deprecated feature: bazelbuild/bazel-skylib#574
|
alexeagle
reviewed
Aug 13, 2025
Contributor
Author
|
The benefit is not seeing a warning in my build output. I don't include
skylib directly iny module, but now I have to, to avoid this warning. It's
not my fault but rules_ocis that I am seeing the warning, so it should be
this modules responsibility to update.
…On Wed, 13 Aug 2025, 11:55 Alex Eagle, ***@***.***> wrote:
***@***.**** commented on this pull request.
technically this should be the lower-bound of what we support. It's up to
users to choose a newer version. Does this change benefit rules_oci itself
in some way?
—
Reply to this email directly, view it on GitHub
<#829 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAXFX65JMR7G7FTNELVK4PT3NKLIZAVCNFSM6AAAAACDUDY57CVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMZTCMJTG4ZDIOBQHE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
thesayyn
approved these changes
Oct 15, 2025
Collaborator
|
Fair enough. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Newer versions address a warning about a deprecated target:
bazelbuild/bazel-skylib#574