Skip to content

fix: use digest when loading image unto daemon#79

Merged
thesayyn merged 3 commits intomainfrom
workspace_name
Mar 7, 2023
Merged

fix: use digest when loading image unto daemon#79
thesayyn merged 3 commits intomainfrom
workspace_name

Conversation

@thesayyn
Copy link
Copy Markdown
Collaborator

No description provided.

@thesayyn thesayyn changed the title fix: handle __main__ and no package gracefully fix: strip illegal characters before constructing default tag Mar 2, 2023
@thesayyn thesayyn requested review from alexeagle and removed request for alexeagle March 3, 2023 13:29
@thesayyn thesayyn changed the title fix: strip illegal characters before constructing default tag fix: use digest when loading image unto daemon Mar 7, 2023
@thesayyn thesayyn requested a review from alexeagle March 7, 2023 15:50
Copy link
Copy Markdown
Collaborator

@alexeagle alexeagle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

actually I think this is a regression.

previously you could write some user instructions like
bazel build :some-image; podman run bazel/some-image:latest
but now you can't predict it anymore

@thesayyn
Copy link
Copy Markdown
Collaborator Author

thesayyn commented Mar 7, 2023

we have oci_tarball for that and people should use that since images guaranteed to have tags you specify via repotags attribute.

@thesayyn thesayyn merged commit 7ab19ac into main Mar 7, 2023
@thesayyn thesayyn deleted the workspace_name branch March 7, 2023 17:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants