fix: make CcInfo/cc dep in nodejs toolchain opt-in via include_headers attribute#3760
Merged
Conversation
12 tasks
6d8c697 to
afbee5a
Compare
afbee5a to
98d12b7
Compare
jbedard
reviewed
Jun 8, 2024
jbedard
approved these changes
Jun 8, 2024
This was referenced Jun 8, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #3722.
Having a
cc_librarytarget always included in theheadersfield of theNodeInfoprovided by the Node.js toolchain means that there must be always c++ toolchain available when using rules_nodejs which is not desirable. This change makes thecc_librarytarget in headers an opt-in via theinclude_headersattribute.Users can set this attribute as follows,
WORKSPACE:
MODULE.bazel