Use headers attribute for toolchains only if it is set#3704
Merged
alexeagle merged 1 commit intoNov 16, 2023
Conversation
This effectively establishes backward compatibility with users of previous
rules_nodejs that create custom toolchains and do not pass the `headers`
attribute to `node_toolchain` which would otherwise fail with:
```
ERROR: /.../external/rules_haskell_nix_node_toolchain/BUILD:4:15: in node_toolchain rule @rules_haskell_nix_node_toolchain//:node_nixpkgs:
Traceback (most recent call last):
File "/.../external/rules_nodejs/nodejs/toolchain.bzl", line 102, column 43, in _node_toolchain_impl
"CcInfo": ctx.attr.headers[CcInfo],
Error: type \'NoneType\' has no operator [](Provider)
```
alexeagle
approved these changes
Nov 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This effectively establishes backward compatibility with users of previous
rules_nodejs that create custom toolchains and do not pass the
headersattribute to
node_toolchainwhich would otherwise fail with:See comments in #3694
cc @DavidZbarsky-at
PR Checklist
Please check if your PR fulfills the following requirements:
PR Type
What kind of change does this PR introduce?
What is the current behavior?
Issue Number: N/A
What is the new behavior?
Does this PR introduce a breaking change?
Other information