ensure that run_in targets include direct tool deps#94
Merged
markelliot merged 1 commit intobazel-contrib:mainfrom Aug 27, 2025
Merged
ensure that run_in targets include direct tool deps#94markelliot merged 1 commit intobazel-contrib:mainfrom
markelliot merged 1 commit intobazel-contrib:mainfrom
Conversation
This change makes sure that, if the tool is a http_file, that the file's //downloaded target ends up in the runfiles set.
Contributor
Author
|
I wanted to write a test for this, but the tests in the examples/module directory fail locally for me, so I wasn't sure what to do about that. |
alexeagle
approved these changes
Aug 27, 2025
Contributor
alexeagle
left a comment
There was a problem hiding this comment.
Looks right to me. I wonder if this was always broken?
Contributor
Author
|
I suspect the problem came from 08e2aeb |
Collaborator
|
I think my original understanding was that the executable is automatically included in the runfiles |
Contributor
Author
|
Yeah, I would have assumed that too! I ended up just looking at a bunch of projects by fmeum to see what those projects did, and just did the same. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This change makes sure that, if the tool is a http_file, that the file's //downloaded target ends up in the runfiles set.