Export a list of all tools in a hub as a Starlark constant#75
Merged
apalmer-theorem merged 1 commit intobazel-contrib:mainfrom May 5, 2025
Merged
Export a list of all tools in a hub as a Starlark constant#75apalmer-theorem merged 1 commit intobazel-contrib:mainfrom
apalmer-theorem merged 1 commit intobazel-contrib:mainfrom
Conversation
This makes it easy to consume all available tools in other rules, such as `bazel_env.bzl`. Strict visibility between modules using rules_multitool is preserved by requiring a `load` from the hub repo, which explicitly doesn't allow discovery of hub names.
Member
Author
|
@apalmer-theorem Could you take a look? The linked issue provides more context, rules_multitool would work pretty well with bazel_env.bzl after this PR. |
markelliot
approved these changes
May 4, 2025
Contributor
|
Awesome thanks @fmeum |
apalmer-theorem
approved these changes
May 5, 2025
Member
Author
|
@apalmer-theorem I would highly appreciate a release with this change. I would then be able to add test coverage and an example using rules_multitool to bazel_env.bzl. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This makes it easy to consume all available tools in other rules, such as
bazel_env.bzl.Strict visibility between modules using rules_multitool is preserved by requiring a
loadfrom the hub repo, which explicitly doesn't allow discovery of hub names.Fixes buildbuddy-io/bazel_env.bzl#32