Skip to content

Exclude cgotest from stdlib build#4524

Merged
dzbarsky merged 1 commit intomasterfrom
zbarsky/cgotest
Dec 2, 2025
Merged

Exclude cgotest from stdlib build#4524
dzbarsky merged 1 commit intomasterfrom
zbarsky/cgotest

Conversation

@dzbarsky
Copy link
Copy Markdown
Contributor

@dzbarsky dzbarsky commented Nov 30, 2025

It didn't build for me with a zig toolchain, but anyway we shouldn't need to build this for user code

# net/internal/cgotest
bazel-out/darwin_arm64-opt-exec-ST-6c94b0e707c0/bin/external/rules_go+/stdlib_/src/net/internal/cgotest/resstate.go:10:10: fatal error: 'resolv.h' file not found
   10 | #include <resolv.h>

What type of PR is this?
Perf tweak?

@linzhp
Copy link
Copy Markdown
Contributor

linzhp commented Nov 30, 2025

This only happen on macOS, right? Zig toolchain cannot build for macOS right now. Can we only exclude this tests for macOS builds?

@dzbarsky dzbarsky merged commit 25f9eca into master Dec 2, 2025
4 checks passed
@dzbarsky dzbarsky deleted the zbarsky/cgotest branch December 2, 2025 04:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@fmeum fmeum fmeum approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@dzbarsky @linzhp @fmeum