go/tools/gopackagesdriver: don't filter GoFiles for tags#4519
Merged
jayconrod merged 1 commit intobazel-contrib:masterfrom Nov 24, 2025
Merged
go/tools/gopackagesdriver: don't filter GoFiles for tags#4519jayconrod merged 1 commit intobazel-contrib:masterfrom
jayconrod merged 1 commit intobazel-contrib:masterfrom
Conversation
fmeum
approved these changes
Nov 22, 2025
Member
fmeum
left a comment
There was a problem hiding this comment.
Looks correct according to https://pkg.go.dev/golang.org/x/tools@v0.39.0/go/packages#Package
@jayconrod Do you agree?
GoFiles should contain all files, ignoring any build tags
9157dd6 to
769b0bb
Compare
jayconrod
approved these changes
Nov 24, 2025
Collaborator
jayconrod
left a comment
There was a problem hiding this comment.
Seems correct. I'm a little worried about tools seeing multiple definitions in different files (e.g., a Windows implementation and a Linux implementation), but the documentation is pretty clear about the distinction between GoFiles and CompiledGoFiles, so we should follow that.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
GoFiles should contain all files, ignoring any build tags