Skip to content

Transition request_nogo to False for cgo_context_data#4512

Merged
fmeum merged 2 commits intobazel-contrib:masterfrom
cerisier:non_nogo_cgo_context_data
Nov 14, 2025
Merged

Transition request_nogo to False for cgo_context_data#4512
fmeum merged 2 commits intobazel-contrib:masterfrom
cerisier:non_nogo_cgo_context_data

Conversation

@cerisier
Copy link
Copy Markdown
Contributor

@cerisier cerisier commented Nov 14, 2025

This is to avoid cc toolchain dependencies in different configurations.

I feel this is fine since cgo_context_data only calls cc toolchain APIs.

The specific case which triggered this PR is cerisier/toolchains_llvm_bootstrapped#45 (comment) where paths provided by CC toolchain would end up being included multiple times in the linker invocation but with different configuration-specific output directory, one of which was non existent in the linker action sandbox.

Looking at the difference between the 2 configurations shows:

FragmentOptions user-defined {
  @@rules_go+//go/private:request_nogo: null, true
}

which felt non necessary for CGO CC toolchain dependencies.

This is to avoid cc toolchain dependencies in different configurations.
@cerisier cerisier force-pushed the non_nogo_cgo_context_data branch from e5571a0 to 99de6ef Compare November 14, 2025 20:35
Copy link
Copy Markdown
Contributor

@dzbarsky dzbarsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice find!

@fmeum fmeum merged commit f836fe6 into bazel-contrib:master Nov 14, 2025
1 check passed
@cerisier cerisier deleted the non_nogo_cgo_context_data branch November 14, 2025 23:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants