Transition request_nogo to False for cgo_context_data#4512
Merged
fmeum merged 2 commits intobazel-contrib:masterfrom Nov 14, 2025
Merged
Transition request_nogo to False for cgo_context_data#4512fmeum merged 2 commits intobazel-contrib:masterfrom
fmeum merged 2 commits intobazel-contrib:masterfrom
Conversation
This is to avoid cc toolchain dependencies in different configurations.
e5571a0 to
99de6ef
Compare
fmeum
approved these changes
Nov 14, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is to avoid cc toolchain dependencies in different configurations.
I feel this is fine since
cgo_context_dataonly calls cc toolchain APIs.The specific case which triggered this PR is cerisier/toolchains_llvm_bootstrapped#45 (comment) where paths provided by CC toolchain would end up being included multiple times in the linker invocation but with different configuration-specific output directory, one of which was non existent in the linker action sandbox.
Looking at the difference between the 2 configurations shows:
which felt non necessary for CGO CC toolchain dependencies.