Allow environment variables to override go_env in @rules_go//go#4464
Merged
fmeum merged 1 commit intobazel-contrib:masterfrom Oct 2, 2025
Merged
Allow environment variables to override go_env in @rules_go//go#4464fmeum merged 1 commit intobazel-contrib:masterfrom
go_env in @rules_go//go#4464fmeum merged 1 commit intobazel-contrib:masterfrom
Conversation
fmeum
approved these changes
Oct 2, 2025
Collaborator
|
Thanks for fixing this! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
This PR fixes an inconsistency in how environment variables interact with
go_env. Prior to this PR, environment variables could override settings ingo_envwithingo_repository, but could not overridego_envwhen invoking@rules_go//go.Which issues(s) does this PR fix?
Fixes #4462
Other notes for review