chore(go_proto_library): Improve error message on incorrect use.#4387
Merged
fmeum merged 3 commits intobazel-contrib:masterfrom Jul 1, 2025
Merged
chore(go_proto_library): Improve error message on incorrect use.#4387fmeum merged 3 commits intobazel-contrib:masterfrom
fmeum merged 3 commits intobazel-contrib:masterfrom
Conversation
It's relatively common for users to add `proto_library` to the `deps` of go_proto_library. The resulting error message (which complains about a missing attribute) is rather confusing, so let's improve it a bit.
fmeum
reviewed
Jul 1, 2025
fmeum
approved these changes
Jul 1, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Other
What does this PR do? Why is it needed?
It's relatively common for users to add
proto_libraryto thedepsof go_proto_library. The resulting error message (which complains about a missing attribute) is rather confusing, so let's improve it a bit.Which issues(s) does this PR fix?
somewhat arguably fixes #4069
Other notes for review