Conversation
This makes it easier to deal with these toolchains in language-agnostic aspects and helpers (in particular, bazel_env.bzl), that propagate to toolchain targets. Even though genrules now support `toolchain_type`s in their `toolchains`, this does *not* allow Go SDKs to be used in genrules as they don't expose the path to the Go binary via a Make variable. This is intentional as we don't want to allow running `go` in `genrule`s.
jayconrod
approved these changes
Jun 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Feature
What does this PR do? Why is it needed?
This makes it easier to deal with these toolchains in language-agnostic aspects and helpers (in particular, bazel_env.bzl), that propagate to toolchain targets.
Even though genrules now support
toolchain_types in theirtoolchains, this does not allow Go SDKs to be used in genrules as they don't expose the path to the Go binary via a Make variable. This is intentional as we don't want to allow runninggoingenrules.Which issues(s) does this PR fix?
Other notes for review