Remove LLVM coverage flags for CGo#3521
Closed
fmeum wants to merge 1 commit intobazel-contrib:masterfrom
Closed
Conversation
achew22
approved these changes
Apr 6, 2023
Member
Author
|
@tyler-french Could you test at Uber? You can directly test #3522, which includes this change. |
tyler-french
approved these changes
Apr 10, 2023
Contributor
tyler-french
left a comment
There was a problem hiding this comment.
Tested bazel coverage with a few CGo targets at Uber
Member
Author
|
Merged in 3b491f1 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Bug fix
What does this PR do? Why is it needed?
We already remove the GCC variants of these flags.