Skip to content

Dependency on golang.org/x/sys/unix missing in 0.14 #1648

@Xjs

Description

@Xjs

0.14.0 upgraded the google.golang.org/grpc dependency to version 1.14 (c73c25f#diff-fdb6ae35486586f3473cd99b5d4c4815R128). However, google.golang.org/grpc introduced a dependency on golang.org/x/sys/unix from 1.13 to 1.14. (Exactly here: grpc/grpc-go@7268ca4#diff-be8985446e731a737c227f2b89d6bf1c)

This leads to targets depending on @org_golang_google_grpc//:go_default_library breaking with rules_go 0.14.0. Artificial example: https://github.com/Xjs/protoTest/tree/v0.14.0. (Breaks on linux only for me, works on Windows, interestingly enough.)

Would it break stuff to add golang.org/x/sys/unix to go/private/repositories.bzl? Am I missing something? (I remember seeing issues relating to golang.org/x/sys/unix...)

Metadata

Metadata

Assignees

No one assigned

    Labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions