Fix building without sandboxing#769
Merged
jsharpe merged 1 commit intobazel-contrib:mainfrom Aug 20, 2021
Merged
Conversation
Member
Author
keith
commented
Aug 20, 2021
Merged
10186cf to
4587f08
Compare
Since 466c32c any changes you made while testing rules_foreign_cc, or changes to those rules, would not invalidate the CMakeCache.txt and lead to build issues. It wasn't the case before that because new temp dirs were used each time.
4587f08 to
f8c5e10
Compare
jsharpe
approved these changes
Aug 20, 2021
Member
jsharpe
left a comment
There was a problem hiding this comment.
Thanks for finding this issue!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since 466c32c any changes you made
while testing rules_foreign_cc, or changes to those rules, would not
invalidate the CMakeCache.txt and lead to build issues. It wasn't the
case before that because new temp dirs were used each time.