cmake_external: allow user to suppress computed cache entries#224
Merged
irengrig merged 1 commit intobazel-contrib:masterfrom Feb 7, 2019
Merged
cmake_external: allow user to suppress computed cache entries#224irengrig merged 1 commit intobazel-contrib:masterfrom
irengrig merged 1 commit intobazel-contrib:masterfrom
Conversation
If the user passes empty string for some cache entry, for instance, CMAKE_BUILD_TYPE, then the corresponding computed value (computed from the Bazel's build type or Bazel C/C++ toolchain) should not be used. I.e., user passes "CMAKE_BUILD_TYPE": "", and there will be no -DCMAKE_BUILD_TYPE in the cmake call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If the user passes empty string for some cache entry, for instance,
CMAKE_BUILD_TYPE, then the corresponding computed value
(computed from the Bazel's build type or Bazel C/C++ toolchain)
should not be used.
I.e., user passes "CMAKE_BUILD_TYPE": "", and there will be no
-DCMAKE_BUILD_TYPE in the cmake call.