Create a new block when the user presses return#187
Closed
matthias-g wants to merge 1 commit intobasecamp:masterfrom
Closed
Create a new block when the user presses return#187matthias-g wants to merge 1 commit intobasecamp:masterfrom
matthias-g wants to merge 1 commit intobasecamp:masterfrom
Conversation
|
+1 |
|
👍 |
Closed
Closed
|
Is this likely to be merged anytime soon ? |
|
+1 |
|
Thanks for this! |
|
+1 |
|
If you need to add a WYIWG editor to your rails app http://quilljs.com/ produce |
|
+1 |
|
For reference we tried to implement this fix manually, but it's possible the fix references a function that no longer exists. We had to move onto an alternate solution because paragraphs wrapped in divs are a deal-breaker for us 😞 |
|
This pull request has been automatically marked as stale after 90 days of inactivity. It will be closed if no further activity occurs. |
|
Any chance of his being merged? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this change a new block is created when the user presses the return key.
This makes it possible to use
Trix.config.blockAttributes.default.tagName = "p"to use<p>tags instead of<div>tags and have a new paragraph created by pressing return (see #117).Pressing shift + return creates just a newline.