Closed
Conversation
Author
|
This is a doc update, the tests look they are failing on the database setup |
Contributor
|
Confirming the same observations 👍 |
Author
|
@byroot Any interest in merging this doc update? If not I'll close the PR. |
Collaborator
|
I think you can close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ran some benchmarks using
derailed_benchmarksfor one of our endpoints that does a lot of data loading. What I noticed was thelineandlines_to_ignoremethods were showing up in the samples a bunch. I did a before and afterperf:ipstest and got a ~25% improvement after removing the:linecomponent. Each test was for 5 minutes, so I'm fairly confident in the results.This PR is just to add a note to the README noting the performance impact of using the
:linecomponent.