Merged
Conversation
If you have multiple roles on the same host, we'll boot them sequentially on that host. This may be important to avoid overloading the server but it's actually just there as a consequence of SSHKit's `on()` method only connecting once per host. To allow roles to boot in parallel on the same host, add a new option: ```yaml boot parallel_roles: true ``` This is implenented by adding a new `on_roles` method that uses a separate thread for each role. It defaults to `false` though as underpowered servers may struggle with booting new containers in parallel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
If you have multiple roles on the same host, we'll boot them sequentially on that host. This may be important to avoid overloading the server but it's actually just there as a consequence of SSHKit's
on()method only connecting once per host.To allow roles to boot in parallel on the same host, add a new option:
This is implenented by adding a new
on_rolesmethod that uses a separate thread for each role.It defaults to
falsethough as underpowered servers may struggle with booting new containers in parallel.