Merged
Conversation
Sometimes we get errors like this in tests:
```
/home/runner/work/kamal/kamal/vendor/bundle/ruby/3.2.0/gems/sshkit-1.24.0/lib/sshkit/backends/connection_pool.rb:139:in `block in run_eviction_loop': #<AnyInstance:Object> was instantiated in CliProxyTest#test_upgrade but it is receiving invocations within
another test. This can lead to unintended interactions between tests and hence unexpected test failures. Ensure that every test correctly cleans up any state that it introduces. (Mocha::StubbingError)
from /home/runner/work/kamal/kamal/vendor/bundle/ruby/3.2.0/gems/sshkit-1.24.0/lib/sshkit/backends/connection_pool.rb:135:in `loop'
from /home/runner/work/kamal/kamal/vendor/bundle/ruby/3.2.0/gems/sshkit-1.24.0/lib/sshkit/backends/connection_pool.rb:135:in `run_eviction_loop'
from /home/runner/work/kamal/kamal/vendor/bundle/ruby/3.2.0/gems/sshkit-1.24.0/lib/sshkit/backends/connection_pool.rb:51:in `block in initialize'
```
The tests still pass, but lets disable the eviction thread to avoid
the error.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Sometimes we get errors like this in tests:
The tests still pass, but lets disable the eviction thread to avoid the error.