Merged
Conversation
* main: Use VFS storage driver locally Fix DNS retry inclusion order Fix indentation DNS retries so lookup failures don't interrupt deploys Combine steps for fewer layers Sudo disk space check Add disk usage monitoring Switch to the VFS storage driver in CI
djmb
approved these changes
Nov 26, 2025
Contributor
There was a problem hiding this comment.
Pull request overview
This PR adds meaningful container names to containers created via app exec commands, replacing Docker's auto-generated random names (like "boring_tesla") with structured names in the format app-web-exec-VERSION-RANDOM. This enables better container management, particularly for filtering exec containers from monitoring and alerting systems.
- Container names now follow the pattern:
{service}-{role}-exec-{version}-{random_hex} - Test assertions updated from exact string matching to regex patterns to accommodate the random suffix
- Random 6-character hex suffix prevents naming conflicts
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| lib/kamal/commands/app/execution.rb | Adds --name flag with container_name_for_exec method to generate structured container names for exec operations |
| test/commands/app_test.rb | Updates test assertions to use regex patterns matching the new container naming scheme |
| test/cli/app_test.rb | Updates CLI test assertions to match new container names with regex patterns |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of a random name like
boring_teslaset a meaningful container name. Useful in our case for excluding these containers from alerting.