Restore ability to specify SSH Configuration property#1688
Merged
djmb merged 4 commits intobasecamp:mainfrom Nov 7, 2025
Merged
Restore ability to specify SSH Configuration property#1688djmb merged 4 commits intobasecamp:mainfrom
djmb merged 4 commits intobasecamp:mainfrom
Conversation
djmb
reviewed
Oct 27, 2025
djmb
reviewed
Oct 27, 2025
djmb
reviewed
Oct 27, 2025
|
|
||
| def type_error(*expected_types) | ||
| error "should be #{expected_types.map { |type| type_description(type) }.join(" or ")}" | ||
| descriptions = expected_types.map { |type| type_description(type) }.uniq |
Collaborator
There was a problem hiding this comment.
Why do we need to uniq the types here?
Contributor
Author
There was a problem hiding this comment.
Calls like validate_type! value, TrueClass, FalseClass, Hash or type_error(TrueClass, FalseClass, String, Array) would result in this:
ERROR (Kamal::ConfigurationError): ssh/config: should be a boolean or a boolean or a string or an array
Contributor
Author
There was a problem hiding this comment.
I'm not a fan of having boolean listed twice.
Collaborator
|
Thanks for this @mike-weiner! I've made a few notes. Looking at the git history, also I don't think this has actually ever worked. |
Contributor
Author
@djmb - Agree. Don't think this ever worked. Requested changes have been made. Should be good to add back to your review list. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #1686.
This PR fixes a gap in functionality where the
.ssh.configproperty was not being passed toSSHKit(and thusNet:SSH) at all.I did confirm that
Net:SSHhas support for this property:https://net-ssh.github.io/net-ssh/Net/SSH.html#method-c-start