Add local registry support for remote builders#1679
Conversation
When running with a remote builder and a local registry: 1. Forward the local registry port to the remote builder 2. Use host networking on the remote builder 3. Use a different builder name as the settings are different A remote builder can only have one port at a time forwarded, so concurrent builds on the same registry port will fail.
ac0d598 to
0055338
Compare
|
Is this released in 2.8.1. I got the same issue, and here is my config: |
|
thanks @djmb I tested this branch It now works when I deploy from my mac but it fails when I deploy from the CI To add more context I tried both with local: true and false and the results where the same Here is the draft PR rubyevents/rubyevents#1096 and the kamal config https://github.com/rubyevents/rubyevents/blob/main/config/deploy.staging.yml let me know if you want me to run any more tests |
|
@adrienpoly - I only see remote builds failing in the action tab. I think the "connection reset by peer" error probably indicates that port forwarding was initially set up correctly, so possibly the SSH connection is being dropped? I've added the keepalive configuration, hopefully that might fix it, but I've also added some logging for any errors in the port forwarding thread, if anything goes wrong there right now I think we are missing it. Could you try building with this branch again when you have a chance? |
8befce9 to
058ba56
Compare
- Include keepalive options when forwarding port for remote builder - Log port forwarding errors.
058ba56 to
10e40a7
Compare
When running with a remote builder and a local registry:
A remote builder can only have one port at a time forwarded, so concurrent builds on the same registry port will fail.
See: #1674 (comment)
cc @jeromedalbert, @adrienpoly