Bumping ed25519 dependency to fix compile errors#1536
Merged
djmb merged 1 commit intobasecamp:mainfrom May 9, 2025
lukef:bump-ed25519
Merged
Bumping ed25519 dependency to fix compile errors#1536djmb merged 1 commit intobasecamp:mainfrom lukef:bump-ed25519
djmb merged 1 commit intobasecamp:mainfrom
lukef:bump-ed25519
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Fedora 42 (and presumably other systems defaulting to GCC 15) Kamal won't build due to incompatible compilation flags in the
ed25519gem that Kamal has a dependency on.The
1.4version oded25519doesn't have any additional features other than housekeeping changes to the repo and the compile flag change so it feels like it is a safe drop in.I have run all the tests in
./bin/testand all tests passed.For additional context, see: