Skip to content

Fix accessory setup#1507

Merged
djmb merged 2 commits intomainfrom
fix-accessory-setup
Apr 18, 2025
Merged

Fix accessory setup#1507
djmb merged 2 commits intomainfrom
fix-accessory-setup

Conversation

@djmb
Copy link
Collaborator

@djmb djmb commented Apr 18, 2025

A couple of fixes for running kamal setup with accessories.

  1. Apply the role filter correctly to accessories when booting
  2. Skip hosts where the accessory is already booted, rather than erroring out.

Fixes: #488 and #935

djmb added 2 commits April 18, 2025 10:20
@djmb
Handle role filter when booting accessories
399f152 
Filter the accessory hosts via KAMAL.accessory_hosts, which correctly
handles role and host filters.

Fixes: #935
@djmb
Skip existing containers on accessory boot
03cac7a 
When booting an accessory, check for the container first and skip boot
if it exists. This allows us to rerun `kamal setup` on hosts with
accessories without raising an error.

Fixes: #488
@djmb djmb merged commit 5c71f2b into main Apr 18, 2025
10 checks passed
@djmb djmb deleted the fix-accessory-setup branch April 18, 2025 10:16
@djmb djmb mentioned this pull request Apr 18, 2025
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

kamal setup crashing on redis accessory

1 participant

@djmb