Enforce JSON output format for aws secrets manager command#1476
Merged
djmb merged 1 commit intobasecamp:mainfrom Apr 15, 2025
Merged
Enforce JSON output format for aws secrets manager command#1476djmb merged 1 commit intobasecamp:mainfrom
djmb merged 1 commit intobasecamp:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently, kamal's aws secretsmanager integration expects all output to be in JSON format. Though the default output format is JSON, aws cli can be configured differently depending on developer preference.1
The easiest way to see this failing in a project that uses aws secretsmanager:
AWS_DEFAULT_OUTPUT=text kamal secrets print ERROR (JSON::ParserError): unexpected character: 'SECRETVALUES arn:aws:secretsmana'This PR enforces the JSON format when running aws secretsmanager commands. Command line option takes precedence over the config file and env variables.2
Footnotes
https://docs.aws.amazon.com/cli/v1/userguide/cli-usage-output-format.html ↩
https://docs.aws.amazon.com/cli/v1/userguide/cli-configure-envvars.html ↩