Skip to content

Set KAMAL_DESTINATION when loading config#1019

Merged
djmb merged 2 commits intobasecamp:mainfrom
nickhammond:ENV/destination
Oct 2, 2024
Merged

Set KAMAL_DESTINATION when loading config#1019
djmb merged 2 commits intobasecamp:mainfrom
nickhammond:ENV/destination

Conversation

@nickhammond
Copy link
Contributor

No description provided.

@jeromedalbert
Copy link
Contributor

jeromedalbert commented Oct 1, 2024

I'm glad to see that this issue is being tackled. I have needed ENV['KAMAL_DESTINATION'] in my config/deploy.yml so I can do Dotenv.load(".kamal/secrets.#{ENV['KAMAL_DESTINATION']}") or something similar with Dotenv.parse.

This PR would remove my hacky workaround of pre-parsing the destination from ARGV in my bin/kamal binstub and setting the environment variable then.

@djmb djmb merged commit 276b469 into basecamp:main Oct 2, 2024
@nickhammond nickhammond deleted the ENV/destination branch October 4, 2024 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants