Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: basecamp/fizzy-cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: v3.0.1
Choose a base ref
...
head repository: basecamp/fizzy-cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: v3.0.2
Choose a head ref
  • 6 commits
  • 9 files changed
  • 1 contributor

Commits on Mar 2, 2026

  1. Convert markdown to HTML before sending to prevent spurious Action Te… 

    …xt attachments

An LLM using the CLI created a card with markdown content that included
a backtick-wrapped `<action-text-attachment>` tag. Since the CLI sent
content as-is, Action Text parsed the literal tag as a real attachment,
triggering Mention::CreateJob and causing errors.

The fix runs all card descriptions and comment bodies through goldmark
(markdown-to-HTML) before sending. This converts backtick-wrapped HTML
tags into escaped `<code>` blocks while passing through raw HTML
unchanged, so real attachments continue to work.

Also fixes parseAttachments to handle <figure> blocks that appear after
the closing </action-text-attachment> tag (caused by goldmark wrapping
bare attachment tags in <p>).
    @robzolkos
    robzolkos committed Mar 2, 2026
    Configuration menu
    Copy the full SHA
    17a91bd View commit details
    Browse the repository at this point in the history

  2. Handle backtick-wrapped attachment tags in mixed HTML/markdown content 

    Goldmark doesn't convert backtick code spans inside HTML blocks, so
backtick-wrapped <action-text-attachment> tags in mixed HTML/markdown
pass through as raw HTML. Add a post-processing step to escape any
attachment tags that remain wrapped in literal backticks.

Also adds an e2e test for the combined case: a real attachment alongside
backtick-wrapped example attachment tags in the same description.
    @robzolkos
    robzolkos committed Mar 2, 2026
    Configuration menu
    Copy the full SHA
    741f785 View commit details
    Browse the repository at this point in the history

  3. Add unit tests for markdown conversion and attachment parsing 

    - TestMarkdownToHTML: 7 tests covering backtick escaping, raw HTML
  passthrough, mixed content, and real alongside backtick attachments
- TestParseAttachments: add case for figure block outside attachment
  tags (p-wrapped HTML from markdown conversion)
- Update TestCommentCreate to expect markdown-converted body
    @robzolkos
    robzolkos committed Mar 2, 2026
    Configuration menu
    Copy the full SHA
    34cd5f6 View commit details
    Browse the repository at this point in the history

  4. Skip markdown conversion for plain text content 

    Plain text without HTML tags or markdown syntax (backticks, angle
brackets) should pass through unchanged to avoid wrapping simple
text in unnecessary <p> tags.

Adds unit test verifying plain text passthrough and reverts the
comment test expectation back to plain text.
    @robzolkos
    robzolkos committed Mar 2, 2026
    Configuration menu
    Copy the full SHA
    134adf3 View commit details
    Browse the repository at this point in the history

  5. Fix attachment parsing with whitespace before trailing figure

    @robzolkos
    robzolkos committed Mar 2, 2026
    Configuration menu
    Copy the full SHA
    9c89d4b View commit details
    Browse the repository at this point in the history

  6. Merge pull request #57 from robzolkos/fix-markdown-attachment-sanitiz… 

    …ation

Fix spurious mentions from literal action-text-attachment tags in CLI content
    @robzolkos
    robzolkos authored Mar 2, 2026
    Configuration menu
    Copy the full SHA
    a822e05 View commit details
    Browse the repository at this point in the history
Loading