Conversation
Picks up two fixes to the generated Go client: - fix(go): omit zero-value optional value-type params (#164) Search no longer sends spurious `sort=` and `page=0`, restoring BC3's relevance ranking for unqualified searches. - fix(spec): rename search query param to `q` (#166) Aligns the SDK with BC3's actual query parameter name.
There was a problem hiding this comment.
Pull request overview
This PR updates the Basecamp Go SDK dependency to address Basecamp search relevancy issues by relying on the newer SDK’s corrected request construction (no empty sort/page=0, and correct query parameter naming for BC3).
Changes:
- Bump
github.com/basecamp/basecamp-sdk/gofromv0.2.2tov0.3.0. - Update Go module checksums (
go.sum) for the new SDK version. - Refresh SDK/API provenance metadata (version + revisions) in
internal/version/sdk-provenance.json.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| internal/version/sdk-provenance.json | Updates recorded SDK version/revision and BC3 API revision provenance. |
| go.mod | Bumps github.com/basecamp/basecamp-sdk/go requirement to v0.3.0. |
| go.sum | Updates checksums for the upgraded SDK module version. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
There was a problem hiding this comment.
LGTM — straightforward SDK version bump with no CLI logic changes.
Extended reasoning...
Overview
This PR bumps basecamp-sdk/go from v0.2.2 to v0.3.0 across three files: go.mod (version line), go.sum (corresponding hashes), and internal/version/sdk-provenance.json (tracking metadata). There are zero logic changes in the CLI repository itself — the bug fix (correcting search query params) lives entirely in the SDK.
Security risks
No security concerns. The change updates a first-party SDK dependency to a newer version. No new dependencies are introduced, no auth or crypto code is touched, and no new network endpoints are added in this repo.
Level of scrutiny
This is a minimal-scrutiny change. Dependency version bumps with only metadata file changes are among the most mechanical PRs possible. The PR description includes a thorough test plan covering the search behavior fix, other endpoint non-regression, and full CI passage.
Other factors
The CODEOWNERS file has a catch-all * rule, but no files in this diff have specific targeted ownership rules. The PR is well-documented with before/after behavior and a comprehensive test plan. No bugs were found by the automated bug hunting system. The minor version bump (0.2 → 0.3) introduces intentional behavioral changes in the SDK, but those changes are the explicit purpose of this PR (fixing search relevance).
Summary
basecamp-sdk/gov0.2.2 → v0.3.0sort=andpage=0, restoring BC3's relevance rankingquery=toq=to match BC3's actual APIBefore:
search.json?query=omacon&sort=&page=0→ recency-sorted, irrelevant resultsAfter:
search.json?q=omacon→ relevance-ranked resultsTest plan
make checkpasses (unit, 263 e2e, lint, vet, fmt, provenance)basecamp search "omacon" -vv→ URL issearch.json?q=omacon, no spurious paramsbasecamp search "omacon" --sort created_at -vv→sort=created_atappears when explicitbasecamp recordings --type Todo --sort created_at -vv→ other endpoints unaffectedSummary by cubic
Search results are now relevance-ranked by default. We upgraded
github.com/basecamp/basecamp-sdk/goto v0.3.0 to useqand stop sending straysortandpage=0.q=for search requests to match BC3.sort=orpage=0.Written for commit 5bd7065. Summary will update on new commits.