Restore error guards on AI labeler edit calls#180
Merged
Conversation
The label snapshot can go stale between gh pr view and the subsequent edits if another workflow or human changes labels concurrently. Keep the 2>/dev/null || true guards so a race doesn't fail the job.
There was a problem hiding this comment.
Pull request overview
This PR restores 2>/dev/null || true error guards on the two gh pr edit calls inside the classify job's "Apply label" step, which were inadvertently removed in #179. Without these guards, a race condition between the label snapshot (gh pr view) and the subsequent edit can cause the workflow to fail if labels change in between. The fix is minimal and surgical.
Changes:
- Restore
2>/dev/null || trueongh pr edit --remove-labelto tolerate stale-snapshot races - Restore
2>/dev/null || trueongh pr edit --add-labelfor the same reason
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
2>/dev/null || trueguards when it made labeling conditionalgh pr viewcan go stale if another workflow or human changes labels between the read and the edit — without guards, that race fails the job2>/dev/null || trueon both remove and add callsTest plan