build EL_8 for RHEL 8 derivatives (Alma, Rocky, CentOS) on rocky linux 8 image#992
Merged
build EL_8 for RHEL 8 derivatives (Alma, Rocky, CentOS) on rocky linux 8 image#992
Conversation
cab06d2 to
7a75d7e
Compare
arogge
reviewed
Dec 2, 2021
arogge
reviewed
Dec 2, 2021
470eef4 to
048426e
Compare
Member
|
I think we currently embed the system we're building on in the binary, so |
048426e to
60a450f
Compare
arogge
previously requested changes
Dec 9, 2021
Member
arogge
left a comment
There was a problem hiding this comment.
We need to repair osinfo.cc somehow.
As a quick fix we could set a custom value for DISTVER on this build.
The real fix would be to make osinfo.cc determine the system's distribution at runtime instead of injecting it at build-time.
arogge
approved these changes
Dec 10, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
As CentOS8 will go out of support by end of the year, we also prepare to build for Rocky LInux.
To build, this PR also requires the merge of changes in:
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing