Fix PostgreSQL create database script and client_min_message level#981
Merged
arogge merged 3 commits intobareos:masterfrom Nov 11, 2021
bruno-at-bareos:5014_Fix_PostgreSQL_create_database_script
Merged
Fix PostgreSQL create database script and client_min_message level#981arogge merged 3 commits intobareos:masterfrom bruno-at-bareos:5014_Fix_PostgreSQL_create_database_script
arogge merged 3 commits intobareos:masterfrom
bruno-at-bareos:5014_Fix_PostgreSQL_create_database_script
Conversation
arogge
requested changes
Nov 11, 2021
bruno-at-bareos
commented
Nov 11, 2021
- Put Encoding and LC directly into SQL create code - Rework the check about encoding and LC Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
- PostgreSQL client_min_message = 'fatal' is no more supported update them all to 'error' or 'warning' level Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
Signed-off-by: Bruno Friedmann <bruno.friedmann@bareos.com>
arogge
approved these changes
Nov 11, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR improve the way we create Bareos database with PostgreSQL and fix the used level for client_min_message to actual valid values.
This need a backport to 20 before 20.0.4 release.
Thank you for contributing to the Bareos Project!
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing