Skip to content

stored: don't unload tapes from blocked devices#973

Merged
arogge merged 2 commits intobareos:masterfrom
arogge:dev/arogge/master/TT4200819
Nov 10, 2021
Merged

stored: don't unload tapes from blocked devices#973
arogge merged 2 commits intobareos:masterfrom
arogge:dev/arogge/master/TT4200819

Conversation

@arogge
Copy link
Member

@arogge arogge commented Nov 8, 2021

This patch changes UnloadOtherDrive() so it won't unload a device that
is not blocked. Previously we only checked if the device was busy, which
might not be enough.

Thank you for contributing to the Bareos Project!

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing

This patch changes UnloadOtherDrive() so it won't unload a device that
is not blocked. Previously we only checked if the device was busy, which
might not be enough.
Copy link
Member

@pstorz pstorz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@arogge arogge merged commit 4f6c5fd into bareos:master Nov 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants