bconsole: fix bconsole crash on autocomplete#969
Merged
arogge merged 3 commits intobareos:masterfrom Nov 18, 2021
Merged
Conversation
ba21c2f to
225097a
Compare
45835a9 to
c0a06fa
Compare
63f182e to
04fed47
Compare
04fed47 to
8a75398
Compare
arogge
requested changes
Nov 18, 2021
Member
arogge
left a comment
There was a problem hiding this comment.
The code itself is finished and should be merged.
However, we should probably merge the commits, especially the ones introducing and removing the -y flag.
Also, feel free to add a CHANGELOG record if you want to.
added 3 commits
November 18, 2021 15:30
Changed the name of the `bconsole-status-client` into `bconsole` so that it would group all basic bconsole tests as subtests systemtest: changed description
8a75398 to
bec8ca3
Compare
arogge
approved these changes
Nov 18, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
A previous PR that helped suppress warnings, made bconsole autocomplete crash. This PR fixes the issue.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests