Skip to content

bconsole: fix bconsole crash on autocomplete#969

Merged
arogge merged 3 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/fix-bconsole-crash-on-autocomplete
Nov 18, 2021
Merged

bconsole: fix bconsole crash on autocomplete#969
arogge merged 3 commits intobareos:masterfrom
alaaeddineelamri:dev/alaaeddineelamri/master/fix-bconsole-crash-on-autocomplete

Conversation

@alaaeddineelamri
Copy link
Contributor

@alaaeddineelamri alaaeddineelamri commented Nov 3, 2021

Description:

A previous PR that helped suppress warnings, made bconsole autocomplete crash. This PR fixes the issue.

Please check

  • Short description and the purpose of this PR is present above this paragraph
  • Your name is present in the AUTHORS file (optional)

If you have any questions or problems, please give a comment in the PR.

Helpful documentation and best practices

Checklist for the reviewer of the PR (will be processed by the Bareos team)

General
  • PR name is meaningful
  • Purpose of the PR is understood
  • Separate commit for this PR in the CHANGELOG.md, PR number referenced is same
  • Commit descriptions are understandable and well formatted
Source code quality
  • Source code changes are understandable
  • Variable and function names are meaningful
  • Code comments are correct (logically and spelling)
  • Required documentation changes are present and part of the PR
  • bareos-check-sources --since-merge does not report any problems
  • git status should not report modifications in the source tree after building and testing
Tests
  • Decision taken that a system- or unittest is required (if not, then remove this paragraph)
  • The decision towards a systemtest is reasonable compared to a unittest
  • Testname matches exactly what is being tested
  • Output of the test leads quickly to the origin of the fault

@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-bconsole-crash-on-autocomplete branch from ba21c2f to 225097a Compare November 4, 2021 09:42
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-bconsole-crash-on-autocomplete branch 2 times, most recently from 45835a9 to c0a06fa Compare November 10, 2021 10:15
@arogge arogge force-pushed the dev/alaaeddineelamri/master/fix-bconsole-crash-on-autocomplete branch from 63f182e to 04fed47 Compare November 12, 2021 17:24
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-bconsole-crash-on-autocomplete branch from 04fed47 to 8a75398 Compare November 15, 2021 09:32
Copy link
Member

@arogge arogge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code itself is finished and should be merged.
However, we should probably merge the commits, especially the ones introducing and removing the -y flag.
Also, feel free to add a CHANGELOG record if you want to.

Alaa Eddine Elamri added 3 commits November 18, 2021 15:30
Changed the name of the `bconsole-status-client` into `bconsole` so that it would group all basic bconsole tests as subtests
systemtest: changed description
@alaaeddineelamri alaaeddineelamri force-pushed the dev/alaaeddineelamri/master/fix-bconsole-crash-on-autocomplete branch from 8a75398 to bec8ca3 Compare November 18, 2021 14:33
@arogge arogge merged commit f9b7e95 into bareos:master Nov 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants