support backup of mariadb using mariabackup#967
Merged
Conversation
2611fd9 to
9b8462c
Compare
49494ad to
9a2bbf0
Compare
158d8c6 to
7a67f06
Compare
bruno-at-bareos
requested changes
Nov 23, 2021
Contributor
bruno-at-bareos
left a comment
There was a problem hiding this comment.
There's little code changes that need to be addressed and also a few files that shouldn't be there.
core/src/plugins/filed/python/mariabackup/BareosFdPluginMariabackup.py
Outdated
Show resolved
Hide resolved
core/src/plugins/filed/python/mariabackup/BareosFdPluginMariabackup.py
Outdated
Show resolved
Hide resolved
core/src/plugins/filed/python/mariabackup/BareosFdPluginMariabackup.py
Outdated
Show resolved
Hide resolved
core/src/plugins/filed/python/mariabackup/BareosFdPluginMariabackup.py
Outdated
Show resolved
Hide resolved
pstorz
commented
Nov 23, 2021
Member
Author
pstorz
left a comment
There was a problem hiding this comment.
Adressed all comments and should be OK now.
41158a8 to
0c67337
Compare
e62d35f to
bbd4b95
Compare
- Update test for mariadb and percona plugin to backup and recover a full database with content verification. - General overhaul and refactoring of testrunners. - The mariabackup and percona tests can and need to be run as unprivileged user. - Package the mariabackup plugin for deb and rpm. - Detect required binaries both for mariadb and for mysql/percona. - Binary specification can be don via commandline which will skip the detection. This is currently required to run both mysql/percona and mariabackup tests as the binary names are identical.
2ecb2d3 to
f5b039f
Compare
bruno-at-bareos
approved these changes
Nov 24, 2021
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
MariaDB has the tool "mariabackup" which offers the same functionality as percona xtrabackup.
This PR introduces a new filedaemon plugin that can backup mariadb servers via mariabackup.
The plugin is based on the percona-xtrabackup plugin.
Also, this PR adds a systemtests that tests the full backup-restore cycle for mariadb and also adds
this functionality to the percona xtrabackup plugin system tests.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
Required documentation changes are present and part of the PRDocumentation will be a separate PR
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests