console: prune command gained support to prune multiple volumes at once#966
Merged
pstorz merged 13 commits intobareos:masterfrom Dec 16, 2021
Conversation
f4bf641 to
891ae04
Compare
891ae04 to
88242f4
Compare
060b70a to
a806203
Compare
d2a8d23 to
384fe89
Compare
arogge
previously requested changes
Dec 9, 2021
Member
arogge
left a comment
There was a problem hiding this comment.
I haven't checked the functionality yet, but I have a few comments about the code.
384fe89 to
27784c6
Compare
added 6 commits
December 14, 2021 11:45
27784c6 to
111f803
Compare
pstorz
requested changes
Dec 14, 2021
Member
pstorz
left a comment
There was a problem hiding this comment.
While testing I found some problems.
The most important is that the output from pruning is stored in the messages buffer, so that now we can call "prune all volume yes", and then we got "you have messages". Then we need to execute "messages" to see what is going on.
I changed the prune and purge functions to log differently so that they now print their results immediately when running in console, and logging to the joblog if a job is the initiator of the pruning. (See last commit)
Besides of this, I added some commtent.
Good work!
12e9bbd to
82bac19
Compare
arogge
reviewed
Dec 15, 2021
pstorz
approved these changes
Dec 15, 2021
pstorz
requested changes
Dec 15, 2021
Member
There was a problem hiding this comment.
I just noticed, that we need to update the "prune command" section in the docs:
https://docs.bareos.org/TasksAndConcepts/BareosConsole.html#index-34
See BareosConsole.rst:891
3cf4b48 to
0eecd63
Compare
... and to the job log when a job is calling the functions. Before, most messages were created via Jmsg(). On interactive usage, the logs were stored in the message buffer instead of showing up immediately. With these changes, the logs created during pruning and purging show up immediately when being used interactively in the console, and will be logged into the job log if pruning and purging are called during a job run.
Co-authored-by: Andreas Rogge <andreas.rogge@bareos.com>
0eecd63 to
49cb664
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
This PR enables the prune command to prune
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing