BareosCheckFunctions: check for chflags()#963
Merged
Conversation
Member
|
Technically, I agree with this. |
Member
Author
|
The description what is done is added and also added a line to the changelog. |
641e918 to
b360458
Compare
arogge
requested changes
Nov 9, 2021
systemtests/tests/chflags/testrunner
Outdated
| #shellcheck source=../scripts/functions | ||
| . "${rscripts}"/functions | ||
|
|
||
| BackupFile="${tmp}/file-with-acl" |
Member
There was a problem hiding this comment.
Naming should use chflags and not acl
Suggested change
| BackupFile="${tmp}/file-with-acl" | |
| BackupFile="${tmp}/file-with-chflags" |
d9d6c54 to
6bcc9d8
Compare
arogge
approved these changes
Nov 11, 2021
6bcc9d8 to
49d3c5b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for contributing to the Bareos Project!
When porting to cmake, accidentially the check for the chflags() function was overseen.
This check is now added with this PR.
This enables the build of the support of backup and restore of BSD File Flags:
In addition to file permissions, FreeBSD supports the use of "file flags". These flags add an additional level of security and control over files, but not directories. With file flags, even root can be prevented from removing or altering files.
Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testingTests