Merged
Conversation
73c8564 to
c86b44f
Compare
c86b44f to
7642dd7
Compare
arogge
approved these changes
Oct 25, 2021
Member
arogge
left a comment
There was a problem hiding this comment.
Looked at it and tested it. Great work - I approve!
arogge
requested changes
Oct 25, 2021
Member
arogge
left a comment
There was a problem hiding this comment.
At second thought: I think we need to update the documentation to reflect this change, too.
arogge
approved these changes
Oct 25, 2021
Member
arogge
left a comment
There was a problem hiding this comment.
Added the required documentation, I think we can merge it now.
fb7d36f to
e7d3049
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds the
releasecommand to other commands allowed to run in scripts.Please check
If you have any questions or problems, please give a comment in the PR.
Helpful documentation and best practices
Checklist for the reviewer of the PR (will be processed by the Bareos team)
General
Source code quality
bareos-check-sources --since-mergedoes not report any problemsgit statusshould not report modifications in the source tree after building and testing